Skip to content

DOCSP-51347: Server Selection #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 25, 2025
Merged

DOCSP-51347: Server Selection #118

merged 7 commits into from
Jul 25, 2025
+177 −0

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jul 17, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-51347

Staging Links

  • connect/connection-options/server-selection
  • connect/connection-options

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    @netlify Netlify
    Copy link

    netlify bot commented Jul 17, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-kotlin-sync ready!

    Name Link
    🔨 Latest commit c40178e
    🔍 Latest deploy log https://app.netlify.com/projects/docs-kotlin-sync/deploys/6883e71c2b05860008ac84cd
    😎 Deploy Preview https://deploy-preview-118--docs-kotlin-sync.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jul 17, 2025 •
    edited
    Loading

    🔄 Deploy Preview for docs-kotlin-sync processing

    Item Details
    🔨 Latest Commit ff21ff672ea44611c032958a0b738fc966b0b658
    😎 Deploy Preview https://deploy-preview-118--docs-kotlin-sync.netlify.app
    🔍 Build Logs View Logs

    shuangela
    shuangela approved these changes Jul 17, 2025
    View reviewed changes
    Copy link
    Collaborator

    @shuangela shuangela left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm % nits

    @mcmorisi mcmorisi marked this pull request as ready for review July 18, 2025 13:03
    @mcmorisi mcmorisi requested a review from a team as a code owner July 18, 2025 13:03
    @mcmorisi mcmorisi requested review from stIncMale and removed request for a team July 18, 2025 13:03
    stIncMale
    stIncMale requested changes Jul 25, 2025
    View reviewed changes
    @stIncMale
    Copy link
    Member

    The last reviewed commit is c3d9175.

    @mcmorisi mcmorisi requested a review from stIncMale July 25, 2025 14:16
    stIncMale
    stIncMale reviewed Jul 25, 2025
    View reviewed changes
    Copy link
    Member

    @stIncMale stIncMale left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I noticed that you resolved some of the conversations on your own. The usual review workflow is that a conversation is resolved by whoever started it, unless it contains a proposed change that was applied via the GitHub UI.

    The last reviewed commit is ff21ff6.

    @mcmorisi mcmorisi closed this Jul 25, 2025
    @mcmorisi mcmorisi reopened this Jul 25, 2025
    @stIncMale
    Copy link
    Member

    The last reviewed commit is c40178e.

    @mcmorisi mcmorisi merged commit 33fb65a into mongodb:comp-cov Jul 25, 2025
    8 of 9 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-51347-server-selection branch July 25, 2025 20:29
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @stIncMale stIncMale stIncMale approved these changes

    @shuangela shuangela shuangela approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @mcmorisi @docs-builder-bot @stIncMale @shuangela